Skip to content

Conversation

@hayemaxi
Copy link
Contributor

It's opening the toolkit global state value instead.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

It's opening the toolkit global state value instead.
@hayemaxi hayemaxi requested a review from a team as a code owner January 13, 2025 22:19
@github-actions

This comment was marked as resolved.

@nkomonen-amazon
Copy link
Contributor

It's opening the toolkit global state value instead.

Does this mean that the Q extension has access to the Toolkit's global state somehow?

In getEnvironmentSpecificMemento() I would have though that globals.globalState would have already been initialized and returned Amazon Q's global state

@justinmk3 justinmk3 merged commit c6d3c12 into aws:master Jan 14, 2025
17 checks passed
@justinmk3
Copy link
Contributor

Does this mean that the Q extension has access to the Toolkit's global state somehow?

Problem is (I think) currently there are Amazon Q (Dev): ... commands and AWS (Dev): ... commands. But the "dev" stuff lives in AWS Toolkit.

avi-alpert pushed a commit to avi-alpert/aws-toolkit-vscode that referenced this pull request Jan 15, 2025
It's opening the toolkit global state value instead.
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
It's opening the toolkit global state value instead.
@hayemaxi hayemaxi deleted the dev branch January 22, 2025 19:56
kevluu-aws pushed a commit to kevluu-aws/aws-toolkit-vscode that referenced this pull request Jan 23, 2025
It's opening the toolkit global state value instead.
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
It's opening the toolkit global state value instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants